Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move patch for AxisTensor component conversion from ClimaAtmos #1474

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Move patch for AxisTensor component conversion from ClimaAtmos #1474

merged 1 commit into from
Oct 4, 2023

Conversation

dennisYatunin
Copy link
Member

This PR moves a monkey patch for AxisTensor component conversion from ClimaAtmos to axistensors.jl. It also adds a unit test for the new functionality.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@dennisYatunin
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 26, 2023
@bors
Try #1474:
a241497
@bors
Copy link
Contributor

bors bot commented Sep 26, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

charleskawczynski
charleskawczynski approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, @simonbyrne, should this be inlined?

@dennisYatunin
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3147194 into main Oct 4, 2023
@bors bors bot deleted the dy/axistensor_patch branch October 4, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisYatunin @charleskawczynski