Check if "ClimaCore version" is already attribute #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe in the future we should consider checking if the version of ClimaCore is the same and allow appending only if it is. |
Sbozzolo
force-pushed
the
gb/fix_attribute
branch
from
1be36f6 to
597eedb
Compare
simonbyrne
reviewed
Sep 19, 2023
HDF5.jl complains if you try writing an attribute that already exists
Sbozzolo
force-pushed
the
gb/fix_attribute
branch
from
597eedb to
c3dc7c5
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 21, 2023
1464: Check if "ClimaCore version" is already attribute r=simonbyrne a=Sbozzolo HDF5.jl complains if you try writing an attribute that already exists, so that appending to `ClimaCore`-generated files can be a problem Co-authored-by: Gabriele Bozzola <[email protected]>
|
Build failed: |
|
I cannot see how this change led to the failing test. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2023
1464: Check if "ClimaCore version" is already attribute r=simonbyrne a=Sbozzolo HDF5.jl complains if you try writing an attribute that already exists, so that appending to `ClimaCore`-generated files can be a problem 1475: Add distributed_remapping.jl r=simonbyrne a=Sbozzolo This pull request introduces a new way to interpolate a field onto a given set of points that works for distributed simulations. This change introduces a new object, a `Remapper`. `Remapper`s are process-local and are defined starting from the target points where we want to interpolate and the `Space`. `Remapper`s contain all the information necessary to perform interpolations of all the fields that are defined on the same `Space`. Once a `Remapper` is defined, it can be used as many times as needed. To use a `Remapper`, just call the new `interpolate` function with the field you want to remap: ```julia remapper = Remapper(hcoords, zcoords, space) interpolate(remapper, field) # => Array of values interpolated on hcoords × zcoords ``` Internally, `interpolate` computes the process-local points and then calls a `MPI.reduce` to return the final value in the root process. Co-authored-by: Gabriele Bozzola <[email protected]>
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDF5.jl complains if you try writing an attribute that already exists, so that appending to
ClimaCore-generated files can be a problem