Allow HDF5Writer to append output #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/append_to_hdf5
branch
from
34d49f6 to
949867a
Compare
simonbyrne
reviewed
Sep 6, 2023
Sbozzolo
force-pushed
the
gb/append_to_hdf5
branch
2 times, most recently
from
26db56c to
438d723
Compare
|
I made the option a keyword and added three lines in the docstring to explain it. |
From https://juliaio.github.io/HDF5.jl/stable/#Opening-and-closing-files cw = read-write, create file if not existing, preserve existing contents
Sbozzolo
force-pushed
the
gb/append_to_hdf5
branch
from
438d723 to
9610520
Compare
simonbyrne
approved these changes
Sep 6, 2023
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an option to
HDF5Writerso that data can be appended to an existing file instead of overwriting it.From https://juliaio.github.io/HDF5.jl/stable/#Opening-and-closing-files
cw = read-write, create file if not existing, preserve existing contents