Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bunch of docs issues #1419

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix a bunch of docs issues #1419

merged 1 commit into from
Aug 9, 2023

Conversation

charleskawczynski
Copy link
Member

There are more, but I think this is a batch that was kind of quick / easier to fix. A step towards #1418.

@valeriabarra
Copy link
Member

I can't visualize/review the preview of the docs via the documenter/deploy GHA. It throws a 404:

image

@charleskawczynski
Copy link
Member Author

I can't visualize/review the preview of the docs via the documenter/deploy GHA. It throws a 404:

I think you maybe clicked it too early? I'm seeing the page show up

@valeriabarra
Copy link
Member

I think you maybe clicked it too early? I'm seeing the page show up

Oh, it was already showing the green check mark and it was marked as completed and I refreshed it a few times. But yeah, I am able to visualize now, too

valeriabarra
valeriabarra reviewed Aug 8, 2023
View reviewed changes
docs/src/api.md Outdated Show resolved Hide resolved
docs/src/api.md Outdated Show resolved Hide resolved
@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 9, 2023
@bors @charleskawczynski
Merge #1419
d5436be 
1419: Fix a bunch of docs issues r=charleskawczynski a=charleskawczynski

There are more, but I think this is a batch that was kind of quick / easier to fix. A step towards #1418.

Co-authored-by: Charles Kawczynski <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 9, 2023

Build failed:

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8be60b8 into main Aug 9, 2023
@bors bors bot deleted the ck/docbuild branch August 9, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriabarra valeriabarra valeriabarra approved these changes

@juliasloan25 juliasloan25 Awaiting requested review from juliasloan25

@sriharshakandala sriharshakandala Awaiting requested review from sriharshakandala

@nefrathenrici nefrathenrici Awaiting requested review from nefrathenrici

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @valeriabarra