Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implict solver test broken with latest DiffEq #409

Closed
jakebolewski opened this issue Jan 10, 2022 · 4 comments
Closed

Implict solver test broken with latest DiffEq #409

jakebolewski opened this issue Jan 10, 2022 · 4 comments
Labels
bug Something isn't working CI Issues releated to CI

Comments

@jakebolewski
Copy link
Contributor

https://buildkite.com/clima/climacore-ci/builds/531#8be6ee1e-981d-4600-b3a7-620c0e28c997/96-101

We should probably pin the diffeq version as the internal API breaks often.
@jakebolewski jakebolewski added bug Something isn't working CI Issues releated to CI labels Jan 10, 2022
@jakebolewski
Copy link
Contributor Author

Marked as known failure for the time being:
eee71ee

@simonbyrne
Copy link
Member

Some discussion in #41 (comment)

@jakebolewski
Copy link
Contributor Author

This is also now impacting the diffeq unit test: https://github.com/CliMA/ClimaCore.jl/runs/4897621853?check_suite_focus=true#step:10:179

@jakebolewski jakebolewski mentioned this issue Jan 21, 2022
Merged
bors bot added a commit that referenced this issue Jan 21, 2022
@bors @jakebolewski
Merge #460
e6d9e64 
460: disable the OrdinaryDiffEq Implict testas it fails post v6.4.2 r=jakebolewski a=jakebolewski

Until #409 is resolved

Co-authored-by: Jake Bolewski <[email protected]>
bors bot added a commit that referenced this issue Jan 21, 2022
@bors @jakebolewski
Merge #460
81f4632 
460: disable the OrdinaryDiffEq Implict test as it fails post v6.4.2 r=jakebolewski a=jakebolewski

Until #409 is resolved

Co-authored-by: Jake Bolewski <[email protected]>
@charleskawczynski
Copy link
Member

Closed by #1401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI Issues releated to CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakebolewski @simonbyrne @charleskawczynski