Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JETTest failing with Julia 1.7 #170

Closed
simonbyrne opened this issue Sep 11, 2021 · 2 comments · Fixed by #221
Closed

JETTest failing with Julia 1.7 #170

simonbyrne opened this issue Sep 11, 2021 · 2 comments · Fixed by #221
Labels
tests upstream

Comments

@simonbyrne
Copy link
Member

e.g. https://github.com/CliMA/ClimaCore.jl/runs/3576785543

@vchuravy @aviatesk any idea what the cause could be?
@aviatesk
Copy link

aviatesk commented Sep 12, 2021 •
edited
Loading

Which Julia version is used ? (EDIT: I missed it's failing on 1.7). It's not compatible with the latest v1.7 nightly because I decided to deprecate JETTest.jl from the next JET.jl release. I'll try to make the next release this week or next week, but for the meanwhile could you turn that test off ? I can make a PR on this repo with updates.

@simonbyrne
Copy link
Member Author

Ah, thanks! Our 1.7 tests are mainly used to find potential problems, so we don't worry too much about them.

@simonbyrne simonbyrne mentioned this issue Sep 13, 2021
Merged
bors bot added a commit that referenced this issue Sep 14, 2021
@bors @simonbyrne
Merge #175
622cb0c 
175: disable fail-fast r=simonbyrne a=simonbyrne

to avoid CI stopping due to #170

Co-authored-by: Simon Byrne <[email protected]>
@jakebolewski jakebolewski mentioned this issue Sep 29, 2021
Merged
@bors bors bot closed this as completed in 535a7ad Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests upstream
Projects
None yet
Milestone
No milestone
3 participants
@jakebolewski @simonbyrne @aviatesk