Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inference regression in ClimaCore 0.10.33 #1223

Closed
charleskawczynski opened this issue May 4, 2023 · 1 comment
Closed

Inference regression in ClimaCore 0.10.33 #1223

charleskawczynski opened this issue May 4, 2023 · 1 comment
Labels
bug Something isn't working performance

Comments

@charleskawczynski
Copy link
Member

Describe the bug

There's an inference regression in ClimaCore 0.10.32 -> ClimaCore 0.10.33.

Here's the flame graph showing what happens after the update:

ClimaCore 0.10.32

Screen Shot 2023-05-04 at 10 04 51 AM

ClimaCore 0.10.33

Screen Shot 2023-05-04 at 10 51 00 AM

I'm not sure what's going on, need time to dig into the issue.

I think we need to be more diligent about inference tests in ClimaCore in general, though. At the moment, it's a bit difficult because JET fails in check_basetype, which is used in many places.
@charleskawczynski charleskawczynski added bug Something isn't working performance labels May 4, 2023
@charleskawczynski charleskawczynski mentioned this issue May 4, 2023
Merged
bors bot added a commit to CliMA/ClimaAtmos.jl that referenced this issue May 4, 2023
@bors @charleskawczynski
Merge #1643
6809696 
1643: Upgrade to latest ClimaCore, ClimaComms and ClimaCoreTempestRemap r=charleskawczynski a=charleskawczynski

This PR upgrades to the latest ClimaCore, ClimaComms and ClimaCoreTempestRemap.

There are some slowdowns with performance regressions in ClimaCore (see CliMA/ClimaCore.jl#1223 for example), but those should be fixable with patch releases.

Co-authored-by: Charles Kawczynski <[email protected]>
bors bot added a commit to CliMA/ClimaAtmos.jl that referenced this issue May 5, 2023
@bors @charleskawczynski
Merge #1643
e9dea90 
1643: Upgrade to latest ClimaCore, ClimaComms and ClimaCoreTempestRemap r=charleskawczynski a=charleskawczynski

This PR upgrades to the latest ClimaCore, ClimaComms and ClimaCoreTempestRemap.

There are some slowdowns with performance regressions in ClimaCore (see CliMA/ClimaCore.jl#1223 for example), but those should be fixable with patch releases.

Co-authored-by: Charles Kawczynski <[email protected]>
bors bot added a commit to CliMA/ClimaAtmos.jl that referenced this issue May 5, 2023
@bors @charleskawczynski
Merge #1643
be54ce4 
1643: Upgrade to latest ClimaCore, ClimaComms and ClimaCoreTempestRemap r=charleskawczynski a=charleskawczynski

This PR upgrades to the latest ClimaCore, ClimaComms and ClimaCoreTempestRemap.

There are some slowdowns with performance regressions in ClimaCore (see CliMA/ClimaCore.jl#1223 for example), but those should be fixable with patch releases.

Co-authored-by: Charles Kawczynski <[email protected]>
@charleskawczynski
Copy link
Member Author

I think this issue is a bit too vague, and most inference failures in ClimaAtmos have been fixed. Closing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charleskawczynski