Merge pull request #1643 from CliMA/gb/faster_interp

Force allocation for interpolate on CPU
CliMA · Mar 12, 2024 · c2c6966 · c2c6966
2 parents a594d69 + 9c45d90
commit c2c6966
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 17 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,12 @@
 ClimaCore.jl Release Notes
 ========================
 
+v0.13.2
+-------
+
+- ![][badge-🐛bugfix] fixed array allocation for interpolation on CPU.
+  PR [#1643](https://github.com/CliMA/ClimaCore.jl/pull/1643).
+
 v0.13.1
 -------
 

diff --git a/src/Remapping/distributed_remapping.jl b/src/Remapping/distributed_remapping.jl
@@ -679,23 +679,6 @@ interpolated data.
 `_collect_and_return_interpolated_values!` is type-unstable and allocates new return arrays.
 """
 function _collect_and_return_interpolated_values!(remapper::Remapper)
-    return _collect_and_return_interpolated_values!(
-        remapper::Remapper,
-        ClimaComms.device(remapper.comms_ctx),
-    )
-end
-
-function _collect_and_return_interpolated_values!(
-    remapper::Remapper,
-    ::ClimaComms.AbstractCPUDevice,
-)
-    ClimaComms.reduce(remapper.comms_ctx, remapper._interpolated_values, +)
-end
-
-function _collect_and_return_interpolated_values!(
-    remapper::Remapper,
-    ::ClimaComms.CUDADevice,
-)
     ClimaComms.reduce!(remapper.comms_ctx, remapper._interpolated_values, +)
     return ClimaComms.iamroot(remapper.comms_ctx) ?
            Array(remapper._interpolated_values) : nothing