wip

.buildkite/pipeline.yml

@@ -693,7 +693,6 @@ steps:
       - label: "Unit: matrix field broadcasting (CPU)"
         key: unit_matrix_field_broadcasting_cpu_scalar_14
         command: "julia --color=yes --check-bounds=yes --project=test test/MatrixFields/matrix_fields_broadcasting/test_scalar_14.jl"
-        soft_fail: true
 
       - label: "Unit: matrix field broadcasting (CPU)"
         key: unit_matrix_field_broadcasting_cpu_scalar_15
@@ -819,7 +818,6 @@ steps:
       - label: "Unit: matrix field broadcasting (GPU)"
         key: unit_matrix_field_broadcasting_gpu_scalar_14
         command: "julia --color=yes --check-bounds=yes --project=test test/MatrixFields/matrix_fields_broadcasting/test_scalar_14.jl"
-        soft_fail: true
         agents:
           slurm_gpus: 1
           slurm_mem: 10GB

src/MatrixFields/matrix_multiplication.jl

@@ -310,8 +310,8 @@ boundary_modified_ud(::BottomRightMatrixCorner, ud, column_space, i) =
     _matrix_rows(ntuple(i -> i + ld1 - 1, ud1 - ld1 + 1), args)
 Base.@propagate_inbounds function _matrix_rows(
     d::Union{Int, PlusHalf{Int}},
-    args,
-)
+    args::T,
+) where {T}
     (
         bc,
         boundary_modified_ld1,
@@ -328,9 +328,9 @@ Base.@propagate_inbounds function _matrix_rows(
         zero(eltype(matrix2)) # This row is outside the matrix.
     end
 end
-Base.@propagate_inbounds _matrix_rows(tup::Tuple, args) =
+Base.@propagate_inbounds _matrix_rows(tup::Tuple, args::T) where {T} =
     (_matrix_rows(first(tup), args), _matrix_rows(Base.tail(tup), args)...)
-Base.@propagate_inbounds _matrix_rows(tup::Tuple{<:Any}, args) =
+Base.@propagate_inbounds _matrix_rows(tup::Tuple{<:Any}, args::T) where {T} =
     (_matrix_rows(first(tup), args),)
 @inline _matrix_rows(tup::Tuple{}, args) = ()
 
@@ -475,4 +475,7 @@ if hasfield(Method, :recursion_relation)
     for m in methods(multiply_matrix_at_index)
         m.recursion_relation = dont_limit
     end
+    for m in methods(matrix_rows)
+        m.recursion_relation = dont_limit
+    end
 end