Merge #294 #295

294: fix syntax error r=simonbyrne a=jakebolewski [skip ci] 295: Fixes a bug in opposing face r=sriharshakandala a=sriharshakandala Fixes a bug in opposing face, that potentially effects single element meshes with periodic boundary conditions. Co-authored-by: Jake Bolewski <[email protected]> Co-authored-by: sriharshakandala <[email protected]>
CliMA · Nov 10, 2021 · 20eebb3 · 20eebb3
3 parents 4da93bd + 80bb4d6 + 77e7bbe
commit 20eebb3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/TagBot.yml b/.github/workflows/TagBot.yml
@@ -24,7 +24,7 @@ jobs:
             {{ custom }}
             {% endif %}
 
-            ## 📢 API Changes:
+            ### 📢 API Changes:
             {% if issues %}
             {% for issue in issues if 'API' in issue.labels %}
             - {{ issue.title }} (#{{ issue.number }})
@@ -36,19 +36,19 @@ jobs:
             {% endfor %}
             {% endif %}
 
-            ## 🚀 Features
+            ### 🚀 Features
             {% if issues %}
             {% for issue in issues if 'enhancement' in issue.labels or 'feature' in issue.labels %}
             - {{ issue.title }} (#{{ issue.number }})
-            {% endfor}
+            {% endfor %}
             {% endif %}
             {% if pulls %}
             {% for pull in pulls if 'enhancement' in pull.labels or 'feature' in pull.labels %}
             - {{ pull.title }} (#{{ pull.number }}) (@{{ pull.author.username }})
             {% endfor %}
             {% endif %}
 
-            ## 📑 Documentation
+            ### 📑 Documentation
             {% if issues %}
             {% for issue in issues if 'documentation' in issue.labels %}
             - {{ issue.title }} (#{{ issue.number }})
@@ -60,7 +60,7 @@ jobs:
             {% endfor %}
             {% endif %}
 
-            ## 🐛 Fixes
+            ### 🐛 Fixes
             {% if issues %}
             {% for issue in issues if 'bug' in issue.labels %}
             - {{ issue.title }} (#{{ issue.number }})

diff --git a/src/Topologies/grid2d.jl b/src/Topologies/grid2d.jl
@@ -46,10 +46,10 @@ function opposing_face(topology::Grid2DTopology, elem::Integer, face::Integer)
     face_neighbors = topology.mesh.face_neighbors
     fc = topology.mesh.elem_faces[elem, face]
 
-    if face_neighbors[fc, 1] == elem
+    if face_neighbors[fc, 1] == elem && face_neighbors[fc, 2] == face
         opelem = face_neighbors[fc, 3]
         opface = face_neighbors[fc, 4]
-    elseif face_neighbors[fc, 3] == elem
+    elseif face_neighbors[fc, 3] == elem && face_neighbors[fc, 4] == face
         opelem = face_neighbors[fc, 1]
         opface = face_neighbors[fc, 2]
     else