Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache flux BCs #880

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Cache flux BCs #880

merged 1 commit into from
Oct 1, 2022

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Oct 1, 2022

This PR caches flux boundary conditions, for

  • dif_flux_uₕ
  • dif_flux_energy
  • dif_flux_ρq_tot
    to address this comment (Operators.SetValue(.-dif_flux_uₕ) is allocating).

Note that it seems that the coupler may be impacted by this, due to the coupled flag. cc @LenkaNovak

A step towards #686.

@szy21
Copy link
Member

szy21 commented Oct 1, 2022

Yes, this will affect the coupler I think. But it should be straightforward to change - just updating e.g. p.dif_flux_uₕ_bc instead of p.dif_flux_uₕ in the coupler.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 1, 2022

Build succeeded:

@bors bors bot merged commit 2640e3b into main Oct 1, 2022
@bors bors bot deleted the ck/cache_bcs branch October 1, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants