More reproducibility infra fixes #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/cleanup_log
branch
from
99d9ef9 to
00f001f
Compare
charleskawczynski
changed the title
charleskawczynski
force-pushed
the
ck/cleanup_log
branch
from
00f001f to
24e98c0
Compare
|
Note to self, we need to update the date of movement so that we only grab files inside the reproducibility folder |
charleskawczynski
force-pushed
the
ck/cleanup_log
branch
from
91d577b to
22987ff
Compare
charleskawczynski
force-pushed
the
ck/cleanup_log
branch
from
22987ff to
bbcc3b2
Compare
Update reproducibility_tests/test_mse.jl Fix Fix hopefully last edge case
charleskawczynski
force-pushed
the
ck/cleanup_log
branch
from
bbcc3b2 to
c75520b
Compare
|
Alright, https://buildkite.com/clima/climaatmos-ci/builds/22104 basically passed. I don't know what happened in Baroclinic wave (ρe) equilmoist (Hughes2023 double mountain config), but it's certainly unrelated to the source code changes in this PR. Since this should (hopefully finally) fix the repro tests, I'm going to manually merge and see how things go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some the log in the reproducibility infrastructure (and should hopefully pass the first new reproducibility tests).