Reorganize restart tests #3351
Merged
Reorganize restart tests #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/automatic_restart
branch
4 times, most recently
from
0b384a9 to
9194803
Compare
Sbozzolo
changed the title
Sbozzolo
force-pushed
the
gb/automatic_restart
branch
3 times, most recently
from
9cd858b to
314a070
Compare
Sbozzolo
force-pushed
the
gb/automatic_restart
branch
4 times, most recently
from
5e2d199 to
67fdec3
Compare
|
GPU + MPI also timed out a couple of times. I removed it and will work on it next. |
Sbozzolo
force-pushed
the
gb/automatic_restart
branch
from
67fdec3 to
55b4f62
Compare
I changed the order of operations: first, I prepare all the `test_dicts`, then, I test all of them. This is so that I can add more `test_dict`s without adding more nesting levels. This commit also adds a check for NCDatasets. NCDatasets contain several stateful objects, so we ignore them in the comparison.
Sbozzolo
force-pushed
the
gb/automatic_restart
branch
from
55b4f62 to
17c0c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables MPI tests for restarts and changes a little bit the structure of the restart test. I changed the order of things because I need to add more complex cases, but I don't want to add more nesting levels. Now, I can push more tests to the test dict directly.