Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining precipitation tests from driver to tests #3033

Merged
merged 1 commit into from
May 22, 2024
Merged

Move remaining precipitation tests from driver to tests #3033

merged 1 commit into from
May 22, 2024

Conversation

trontrytel
Copy link
Member

No description provided.

@trontrytel trontrytel self-assigned this May 20, 2024
@trontrytel trontrytel force-pushed the aj/precip_tests branch 2 times, most recently from da6e134 to b98e854 Compare May 21, 2024 23:00
@trontrytel trontrytel marked this pull request as ready for review May 22, 2024 16:53
akshaysridhar
akshaysridhar approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@akshaysridhar akshaysridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

szy21
szy21 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (And this message is from 35000 feet in the air:)

@charleskawczynski charleskawczynski added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2024
@trontrytel trontrytel mentioned this pull request May 22, 2024
Closed
@trontrytel trontrytel added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 7ce2e3b May 22, 2024
11 checks passed
@trontrytel trontrytel deleted the aj/precip_tests branch May 22, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysridhar akshaysridhar akshaysridhar approved these changes

@szy21 szy21 szy21 approved these changes

@charleskawczynski charleskawczynski charleskawczynski approved these changes

Assignees

@trontrytel trontrytel

Labels
Microphysics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trontrytel @charleskawczynski @szy21 @akshaysridhar