Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the non-orographic gravity wave parameterization #783

Closed
5 of 8 tasks
jiahe23 opened this issue Aug 30, 2022 · 3 comments · Fixed by #852 or #983
Closed
5 of 8 tasks

Implement the non-orographic gravity wave parameterization #783

jiahe23 opened this issue Aug 30, 2022 · 3 comments · Fixed by #852 or #983
Assignees
@szy21 @LenkaNovak @jiahe23
Labels
SDI Software Design Issue

Comments

@jiahe23
Copy link
Contributor

jiahe23 commented Aug 30, 2022 •
edited
Loading

Purpose

Implement the Alexander and Dunkerton (1999) gravity wave (GW) parameterization, using the convective gravity wave source implemented in GFDL.

Other resources

Cost/Benefits/Risks

Benefits:
The parameterization of GW breaking and its forcing on momentum makes a more realistic representation of upper atmospheric circulations (stratosphere and mesosphere).

People and Personnel

(@ the personnel required/requested to implement the software solution)

Components + Algorithm

Results and deliverables

Task Breakdown And Tentative Due Date

Proposed Delivery Date
@jiahe23 jiahe23 added the SDI Software Design Issue label Aug 30, 2022
@tapios
Copy link
Contributor

tapios commented Aug 30, 2022

Looks good to me!

@bischtob
Copy link
Contributor

bischtob commented Sep 8, 2022

Can we add a little more detail here re task breakdown and dates, perhaps in terms of PRs? I am guessing we are targeting a simple driver first?

@jiahe23 jiahe23 changed the title Implement the gravity wave parameterization Implement the non-orographic gravity wave parameterization Sep 8, 2022
@jiahe23 jiahe23 mentioned this issue Sep 19, 2022
Merged
12 tasks
bors bot added a commit that referenced this issue Oct 5, 2022
@bors @jiahe23
Merge #852
d0be7b7 
852: Add non-or0graphic gravity wave parameterization. r=jiahe23 a=jiahe23

Co-authored-by: Zhaoyi Shen <[email protected]>
Co-authored-by: LenkaNovak <[email protected]>

## Purpose and Content
This PR implements the [Alexander and Dunkerton (1999)](https://doi.org/10.1175/1520-0469(1999)056%3C4167:ASPOMF%3E2.0.CO;2) paper for non-orographic gravity wave parameterization.

Examples are added to test agains the cases (Fig. 4 and 8) in the paper.

Help needed from software experts:
- [x] We need a way to read in the `.nc` data file for the tests;
- [ ]  The code may need considerable optimization for a good performance.
`@charleskawczynski` `@simonbyrne`  We appreciate if you could take a look

## Linked Issues
- Closes #783 

## PR Checklist
- [x] This PR has a corresponding issue OR is linked to an SDI.
- [ ] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A.
- [ ] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy).
- [ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
- [ ] I linted my code on my local machine prior to submission OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code used in an integration test OR N/A.
- [ ] All tests ran successfully on my local machine OR N/A.
- [ ] All classes, modules, and function contain docstrings OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Jia He <[email protected]>
bors bot added a commit that referenced this issue Oct 5, 2022
@bors @jiahe23
Merge #852
704b584 
852: Add non-or0graphic gravity wave parameterization. r=charleskawczynski a=jiahe23

Co-authored-by: Zhaoyi Shen <[email protected]>
Co-authored-by: LenkaNovak <[email protected]>

## Purpose and Content
This PR implements the [Alexander and Dunkerton (1999)](https://doi.org/10.1175/1520-0469(1999)056%3C4167:ASPOMF%3E2.0.CO;2) paper for non-orographic gravity wave parameterization.

Examples are added to test agains the cases (Fig. 4 and 8) in the paper.

Help needed from software experts:
- [x] We need a way to read in the `.nc` data file for the tests;
- [ ]  The code may need considerable optimization for a good performance.
`@charleskawczynski` `@simonbyrne`  We appreciate if you could take a look

## Linked Issues
- Closes #783 

## PR Checklist
- [x] This PR has a corresponding issue OR is linked to an SDI.
- [ ] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A.
- [ ] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy).
- [ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
- [ ] I linted my code on my local machine prior to submission OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code used in an integration test OR N/A.
- [ ] All tests ran successfully on my local machine OR N/A.
- [ ] All classes, modules, and function contain docstrings OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Jia He <[email protected]>
bors bot added a commit that referenced this issue Oct 5, 2022
@bors @jiahe23
Merge #852
511d24a 
852: Add non-or0graphic gravity wave parameterization. r=charleskawczynski a=jiahe23

Co-authored-by: Zhaoyi Shen <[email protected]>
Co-authored-by: LenkaNovak <[email protected]>

## Purpose and Content
This PR implements the [Alexander and Dunkerton (1999)](https://doi.org/10.1175/1520-0469(1999)056%3C4167:ASPOMF%3E2.0.CO;2) paper for non-orographic gravity wave parameterization.

Examples are added to test agains the cases (Fig. 4 and 8) in the paper.

Help needed from software experts:
- [x] We need a way to read in the `.nc` data file for the tests;
- [ ]  The code may need considerable optimization for a good performance.
`@charleskawczynski` `@simonbyrne`  We appreciate if you could take a look

## Linked Issues
- Closes #783 

## PR Checklist
- [x] This PR has a corresponding issue OR is linked to an SDI.
- [ ] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A.
- [ ] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy).
- [ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
- [ ] I linted my code on my local machine prior to submission OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code used in an integration test OR N/A.
- [ ] All tests ran successfully on my local machine OR N/A.
- [ ] All classes, modules, and function contain docstrings OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Jia He <[email protected]>
bors bot added a commit that referenced this issue Oct 5, 2022
@bors @jiahe23
Merge #852
7857752 
852: Add non-or0graphic gravity wave parameterization. r=charleskawczynski a=jiahe23

Co-authored-by: Zhaoyi Shen <[email protected]>
Co-authored-by: LenkaNovak <[email protected]>

## Purpose and Content
This PR implements the [Alexander and Dunkerton (1999)](https://doi.org/10.1175/1520-0469(1999)056%3C4167:ASPOMF%3E2.0.CO;2) paper for non-orographic gravity wave parameterization.

Examples are added to test agains the cases (Fig. 4 and 8) in the paper.

Help needed from software experts:
- [x] We need a way to read in the `.nc` data file for the tests;
- [ ]  The code may need considerable optimization for a good performance.
`@charleskawczynski` `@simonbyrne`  We appreciate if you could take a look

## Linked Issues
- Closes #783 

## PR Checklist
- [x] This PR has a corresponding issue OR is linked to an SDI.
- [ ] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A.
- [ ] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy).
- [ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
- [ ] I linted my code on my local machine prior to submission OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code used in an integration test OR N/A.
- [ ] All tests ran successfully on my local machine OR N/A.
- [ ] All classes, modules, and function contain docstrings OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Jia He <[email protected]>
@bors bors bot closed this as completed in ce21644 Oct 5, 2022
@jiahe23
Copy link
Contributor Author

jiahe23 commented Oct 5, 2022

#852 partially resolved this issue; it provided a single column implementation.

GCM integration is still wip.

@jiahe23 jiahe23 reopened this Oct 5, 2022
@jiahe23 jiahe23 mentioned this issue Oct 19, 2022
Merged
bors bot added a commit that referenced this issue Oct 27, 2022
@bors @jiahe23
Merge #983
2f47543 
983: Non orographic gw parameterization for GCM configurations r=jiahe23 a=jiahe23

## Purpose 
This PR integrates GW parameterization with GCM configuration, and adds an example into buildkite.

Differences in its integration into single column (as described in the paper) vs gcm (as in GFDL codes) configurations:
- source level identification: fixed height in single column vs fixed pressure in gcm;
- source amplitude: fixed number in single column vs latitude dependency in gcm.

These differences require different cache variables and forcing computations for the two setups.


Closes #783 


Co-authored-by: Jia He <[email protected]>
@bors bors bot closed this as completed in 1cedb39 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szy21 szy21

@LenkaNovak LenkaNovak

@jiahe23 jiahe23

Labels
SDI Software Design Issue
Projects
None yet
Milestone
No milestone
7 participants
@simonbyrne @szy21 @bischtob @cmbengue @tapios @LenkaNovak @jiahe23