Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CUDA - take 2 #2218

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Update CUDA - take 2 #2218

merged 2 commits into from
Oct 11, 2023

Conversation

charleskawczynski
Copy link
Member

This PR upgrades the dependencies. Notably, to CUDA 5.0. Supersedes #2199.

@simonbyrne
Copy link
Member

Is it related to

┌ Warning: @cuprint does not support values of type Nothing
└ @ CUDA /central/scratch/esm/slurm-buildkite/climaatmos-ci/depot/cpu/packages/CUDA/nbRJk/src/device/intrinsics/output.jl:170

@simonbyrne
Copy link
Member

Maybe try handling the T_guess::Nothing case differently here:
https://github.com/CliMA/Thermodynamics.jl/blob/b49cb7249d275b6f3d7a0aafa0eed700b9091147/src/config_numerical_method.jl#L24-L33

@charleskawczynski
Copy link
Member Author

Maybe? I can add a hot fix. I'll probably need to fix Thermodynamics CUDA CI, first (assuming that it's breaking like RootSolvers)

@charleskawczynski
Copy link
Member Author

Alright, I've released a new version of Thermodynamics that doesn't potentially print nothing. Let's see how this goes 🤞🏻

@charleskawczynski
Copy link
Member Author

That was it!

@charleskawczynski
Copy link
Member Author

bors r+

@charleskawczynski charleskawczynski mentioned this pull request Oct 11, 2023
Closed
@bors
Copy link
Contributor

bors bot commented Oct 11, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 36429e9 into main Oct 11, 2023
7 of 8 checks passed
@bors bors bot deleted the ck/up_cuda2 branch October 11, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dependencies 🕸️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @simonbyrne