Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(SDK - 3906) - Remove cross btn from five icons #632

Merged

Conversation

Anush-Shand
Copy link
Contributor

  • Removes cross btn from five-icons
  • Removes setOngoing(true) to make it non-sticky across all OS versions
  • Deletes unused icon

- Removes cross btn from five-icons
- Removes setOngoing(true) to make it non-sticky across all OS versions
- Deletes unused icon
@Anush-Shand Anush-Shand changed the title task(SDK - 3906) task(SDK - 3906) - Remove cross btn from five icons Jul 4, 2024
@Anush-Shand Anush-Shand self-assigned this Jul 4, 2024
@Anush-Shand Anush-Shand added the ptv1.2.4 New Release for push-templates label Jul 4, 2024
@CTLalit CTLalit requested a review from piyush-kukadiya July 8, 2024 13:12
@CTLalit CTLalit changed the base branch from develop to feat/bugs/core700qa July 8, 2024 13:16
Copy link
Contributor

@piyush-kukadiya piyush-kukadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove close related changes from PendingIntentFactory

@piyush-kukadiya
Copy link
Contributor

Update CTPUSHTEMPLATES.md

@piyush-kukadiya
Copy link
Contributor

update CTPUSHTEMPLATESANDROID12.md

@piyush-kukadiya
Copy link
Contributor

Crosscheck other places by performing global search on five icon related keywords.

@piyush-kukadiya
Copy link
Contributor

Will old notifications dismiss after updating App with new SDK?

@CTLalit CTLalit merged commit 09fd33b into feat/bugs/core700qa Jul 9, 2024
3 checks passed
Copy link
Contributor

@piyush-kukadiya piyush-kukadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ptv1.2.4 New Release for push-templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants