Bug/sdk 3671 #577
Merged
Bug/sdk 3671 #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed init of variables in class first before using them in deviceInfo
- did not use device id from state variable (shared pref map) - instead passed device id back from func as it is created on fly - this reduces risk of state variable changing over time as it is accessed in future
- simplified ternary as it would always return null in both cases
- the device id passed as method return type to be used - did not fetch device id from state (shared pref map)
| @@ -2767,13 +2767,13 @@ void deviceIDCreated(String deviceId) { | |||
| StoreProvider storeProvider = StoreProvider.getInstance(); | |||
|
|
|||
| if (storeRegistry.getInAppStore() == null) { | |||
| InAppStore inAppStore = storeProvider.provideInAppStore(context, cryptHandler, deviceInfo, | |||
| InAppStore inAppStore = storeProvider.provideInAppStore(context, cryptHandler, deviceId, | |||
There was a problem hiding this comment.
@CTLalit passing deviceId instead of deviceInfo will not solve null pointer exception. I believe deviceId will also be null here.
There was a problem hiding this comment.
generated the device id and passed it as function return type, can you elaborate some null cases?
There was a problem hiding this comment.
as discussed on call this can be resolved
- comment fixed - seems some unreachable code can be due to legacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wizrocket.atlassian.net/browse/SDK-3671
fixed init of variables in class first before using them in deviceInfo
did not use device id from state variable (shared pref map)
instead passed device id back from func as it is created on fly
this reduces risk of state variable changing over time as it is accessed in future
simplified ternary as it would always return null in both cases
the device id passed as method return type to be used
did not fetch device id from state (shared pref map)