Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3459] Unit tests for ImpressionManager #513

Merged
merged 11 commits into from
Dec 13, 2023
Merged

[SDK-3459] Unit tests for ImpressionManager #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
303bef0
feat(inapp) - add unit tests for recordImpression(), perSession() and…
shivamsharma2710 Dec 4, 2023
88b4fcd
feat(inapp) - add unit tests for perSecond() in EvaluationManagerTest…
shivamsharma2710 Dec 5, 2023
8c58499
feat(inapp) - add unit tests for perMinute() in EvaluationManagerTest…
shivamsharma2710 Dec 5, 2023
2988cdc
feat(inapp) - add unit tests for testPerHour() in EvaluationManagerTe…
shivamsharma2710 Dec 5, 2023
e02b506
feat(inapp) - refactor unit tests coverage for perSecond() and perMin…
shivamsharma2710 Dec 5, 2023
a960d2d
feat(inapp) - add unit tests for testPerDay() method
shivamsharma2710 Dec 6, 2023
023f7cc
feat(inapp) - add unit tests for perWeek() method
shivamsharma2710 Dec 7, 2023
9d1a6fb
feat(inapp) - add unit tests for perSessionTotal() method
shivamsharma2710 Dec 7, 2023
3e7d246
feat(inapp) - reformat code
shivamsharma2710 Dec 7, 2023
cc1ff2a
feat(inapp) - make getImpressionCount methods private
shivamsharma2710 Dec 7, 2023
eff3560
feat(inapp) - add javaDoc details to the perWeek() method
shivamsharma2710 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/ImpressionManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ class ImpressionManager @JvmOverloads constructor(

/**
* Counts the impressions for a campaign within the last N weeks.
* It looks up in the current week if the value one is passed as week offset
*
* @param campaignId The identifier of the campaign.
* @param weeks The time interval in weeks.
Expand Down Expand Up @@ -177,7 +178,7 @@ class ImpressionManager @JvmOverloads constructor(
* @param campaignId The identifier of the campaign.
* @return The total number of impressions recorded for the campaign.
*/
fun getImpressionCount(campaignId: String): Int {
private fun getImpressionCount(campaignId: String): Int {
return storeRegistry.impressionStore?.read(campaignId)?.size ?: 0
}

Expand All @@ -188,7 +189,7 @@ class ImpressionManager @JvmOverloads constructor(
* @param timestampStart The start timestamp of the time interval (in seconds since the Unix epoch).
* @return The count of impressions within the specified time interval.
*/
fun getImpressionCount(campaignId: String, timestampStart: Long): Int {
private fun getImpressionCount(campaignId: String, timestampStart: Long): Int {
val timestamps = getImpressions(campaignId)

var count = 0
Expand Down
Loading