-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: InApp Feature Parity #482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppController SDK-3384
…pressed in-app and let InAppController handle displaying in-app SDK-3384
…ner and let InAppController handle display of client side in-apps on app launch event SDK-3384
…first non-suppressed in-app SDK-3384
…vertap-android-sdk into client_side_inapps � Conflicts: � clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/evaluation/EvaluationManager.kt
… String and add NetworkHeadersListener logic SDK-3384
…ps with network request headers SDK-3385
…vertap-android-sdk into client_side_inapps
…vertap-android-sdk into client_side_inapps
shivamsharma2710
force-pushed
the
client_side_inapps
branch
from
November 6, 2023 06:25
f7163c5
to
2554e7e
Compare
…mCaps in the configureWithJson method
…g when there's no network
…vertap-android-sdk into client_side_inapps
- timeouts are less for PN image download
- do not cache large resources - also evict stale resource in that case since cache will return incorrect entry
- it was not needed
# Conflicts: # clevertap-core/src/main/java/com/clevertap/android/sdk/events/EventQueueManager.java
- do not need a store class per user level - removed the dependency on device id initisation for initialising asset store
…device is offline SDK-3587
- this was due to backpressed deprecation - based on android os version and certain gesture flags the back pressed does not get called in some apps - handled by removed code from back pressed and moving to finish and destroy
CTLalit
approved these changes
Jan 15, 2024
piyush-kukadiya
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wizrocket.atlassian.net/browse/SDK-3106