Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: InApp Feature Parity #482

Merged
merged 312 commits into from
Jan 15, 2024
Merged

DRAFT: InApp Feature Parity #482

merged 312 commits into from
Jan 15, 2024

Conversation

shivamsharma2710
Copy link
Contributor

@shivamsharma2710 shivamsharma2710 commented Oct 16, 2023

piyush-kukadiya and others added 25 commits October 30, 2023 14:39
…pressed in-app and let InAppController handle displaying in-app SDK-3384
…ner and let InAppController handle display of client side in-apps on app launch event SDK-3384
…vertap-android-sdk into client_side_inapps

� Conflicts:
�	clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/evaluation/EvaluationManager.kt
… String and add NetworkHeadersListener logic SDK-3384
shivamsharma2710 and others added 24 commits January 9, 2024 23:15
- timeouts are less for PN image download
- do not cache large resources
- also evict stale resource in that case since cache will return incorrect entry
- it was not needed
# Conflicts:
#	clevertap-core/src/main/java/com/clevertap/android/sdk/events/EventQueueManager.java
- do not need a store class per user level
- removed the dependency on device id initisation for initialising asset store
- this was due to backpressed deprecation
- based on android os version and certain gesture flags the back pressed does not get called in some apps
- handled by removed code from back pressed and moving to finish and destroy
@CTLalit CTLalit marked this pull request as ready for review January 15, 2024 10:56
Copy link
Contributor

@piyush-kukadiya piyush-kukadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CTLalit CTLalit merged commit 611144e into develop Jan 15, 2024
4 checks passed
@CTLalit CTLalit deleted the client_side_inapps branch March 1, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants