Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2445]: add support to register multiple push primer listeners #368

Merged

Conversation

shivamsharma2710
Copy link
Contributor

No description provided.

Copy link
Contributor

@piyush-kukadiya piyush-kukadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* This method registers the PushPermissionNotificationResponseListener.
* <p>
* Make sure to unregister the listener in onDestroy() or onPause() of the activity/fragment if the
* listener is registered in onCreate() or onResume() respectively.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamsharma2710 Please mention to call this register method only in onCreate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please check now.

Copy link
Collaborator

@darshanclevertap darshanclevertap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamsharma2710 Please mention to call this register method only in onCreate method

@piyush-kukadiya piyush-kukadiya merged commit 29469c5 into develop Dec 5, 2022
@piyush-kukadiya piyush-kukadiya deleted the task/SDK-2445/support_multiple_push_primer_listeners branch December 5, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants