Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PushProviders : calling findCTPushProviders in async and findCustomEnabledPushTypes in async success callback #360

Merged
merged 6 commits into from
Dec 5, 2022
Merged

PushProviders : calling findCTPushProviders in async and findCustomEnabledPushTypes in async success callback #360

merged 6 commits into from
Dec 5, 2022

Conversation

root-ansh-ct
Copy link
Contributor

@root-ansh-ct root-ansh-ct commented Nov 14, 2022 •
edited
Loading

SDK-2380 : made calls to findCTPushProvider and findCustomEnabledPushTypes async . Fixes ANR on PackageUtils impacting SUC-119886

piyush-kukadiya
piyush-kukadiya approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@piyush-kukadiya piyush-kukadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piyush-kukadiya piyush-kukadiya merged commit a45d5e8 into develop Dec 5, 2022
@piyush-kukadiya piyush-kukadiya deleted the task/noc/SDK-2380 branch December 5, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-kukadiya piyush-kukadiya piyush-kukadiya approved these changes

@darshanclevertap darshanclevertap darshanclevertap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@root-ansh-ct @darshanclevertap @piyush-kukadiya @william-ct