UPS follow up fixes #9664
UPS follow up fixes #9664
Conversation
Applies to the active armor items.
…s no iuse function.
| if( active && !is_food() && ( type->id.length() < 3 || type->id.compare( type->id.length() - 3, 3, "_on" ) != 0 ) ) { | ||
| // Usually the items whose ids end in "_on" have the "active" or "on" string already contained | ||
| // in their name, also food is active while it rots. | ||
| ret << _( " (active)" ); |
There was a problem hiding this comment.
Same with corpses. Test targets for the shotgun PR were (active) after I'd downed 'em. This was a bad idea on my part, and I'll remove/fix it as part of the merge. Sorry to waste your time, BevapDin.
There was a problem hiding this comment.
In this case, I'll add a the tag in the inventory ui, and only for worn items.
There was a problem hiding this comment.
I added a !is_corpse() check. Seemed to achieve the goal.
(Reason tanksuits benefit from the (active) is that when they're highlighted in the inventory--which they tend to be, since you can't wear anything under them--the highlight cancels the yellow text. So you'd need to have a helmet or frame, then flip over to that list and move the highlight down to check.)
Fixes the issues from that comment over there #9652 (comment)
Seems to be a general problem, it's the same for the both forges. They have no iuse function, so the game does nothing when invoked. I added a message for that case.
That seems to have been overlooked in eff239b, it needs to check against
maximum_chargeslike it does for items in the inventory, fixed.That's another bug. I've only seen them yellow in the inventory window, that was enough for me. But I added another item suffix for those items that are active, but have no separate active item type. Usually the active item type has the id "foo_on", so it checks whether the item id has the suffix "_on" and if not adds "(active)" to the item name.