-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xedra Evolved] Paraclesian spell scaling fixes #79271
Merged
GuardianDll
merged 10 commits into
CleverRaven:master
from
rty275:paraclesian-scaling-fix
Jan 21, 2025
Merged
[Xedra Evolved] Paraclesian spell scaling fixes #79271
GuardianDll
merged 10 commits into
CleverRaven:master
from
rty275:paraclesian-scaling-fix
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Xedra Evolved
Anything to do with Xedra Evolved
<Bugfix>
This is a fix for a bug (or closes open issue)
labels
Jan 20, 2025
data/mods/Xedra_Evolved/mutations/paraclesians/homullus_mutation_spells.json
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Jan 20, 2025
…_spells.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…on_spells.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixes scaling of some Paraclesian spells"
Purpose of change
I noticed in an arvore playthrough that Roots Crack the Foundation wasn't having nearly as much effect as I thought it would, so I checked the files and discovered that it was scaling off the wrong id. Then, I checked the other paraclesian spells to see if any other minor errors might have happened.
Describe the solution
Set the spells to scale off the correct ids.
Describe alternatives you've considered
Not fixing the bugs?
Testing
Game loaded with edited files. Tested all three spells at low and then high levels, scaling seems to have successfully happened.
Additional context
Side note, the ids of the paraclesian spells are in dire need of some kind of standardization. I would do so myself, but I don't know how to migrate spells, and I think changing spell ids would break playthroughs in progress if someone were to inadvisably update.