Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Paraclesian spell scaling fixes #79271

Merged
merged 10 commits into from
Jan 21, 2025

Conversation

rty275
Copy link
Contributor

@rty275 rty275 commented Jan 20, 2025

Summary

Bugfixes "Fixes scaling of some Paraclesian spells"

Purpose of change

I noticed in an arvore playthrough that Roots Crack the Foundation wasn't having nearly as much effect as I thought it would, so I checked the files and discovered that it was scaling off the wrong id. Then, I checked the other paraclesian spells to see if any other minor errors might have happened.

Describe the solution

Set the spells to scale off the correct ids.

Describe alternatives you've considered

Not fixing the bugs?

Testing

Game loaded with edited files. Tested all three spells at low and then high levels, scaling seems to have successfully happened.

Additional context

Side note, the ids of the paraclesian spells are in dire need of some kind of standardization. I would do so myself, but I don't know how to migrate spells, and I think changing spell ids would break playthroughs in progress if someone were to inadvisably update.

@github-actions github-actions bot requested a review from Maleclypse January 20, 2025 20:28
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 20, 2025
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 20, 2025
rty275 and others added 7 commits January 20, 2025 14:23
…_spells.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…spells.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…on_spells.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 20, 2025
@GuardianDll GuardianDll merged commit 1a0afd4 into CleverRaven:master Jan 21, 2025
28 checks passed
@rty275 rty275 deleted the paraclesian-scaling-fix branch January 21, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants