Add message when trying to hack unhackable card-readers #79267
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Partially resolves #79193
Previously when you examined a unhackable card-reader with a functional hacking tool, nothing would happen, which was confusing.
Describe the solution
Add a message when examining a unhackable card-reader.
Describe alternatives you've considered
Testing
Examine unhackable reader, get message
Additional context
@kevingranade is there a reason some readers introduced in #50033 are unhackable? EG
t_card_science_transport_1There doesn't seem to be anything that differentiates them to explain it. Maybe the description should be updated to mention why they are unhackable?