[Aftershock] Audit Aftershock Mapgen for lighting consistency #79221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Aftershock] Audit nearly all Aftershock maps to consistently use the new light status parameter palette."
Purpose of change
There is a lot of inconsistency and redundancy in how Aftershock handles lighting or not lighting it's maps. (Mostly my fault)
Describe the solution
In the Gene Clinics PR I added a new standardized palette to handle lighting. This PR now aims to just move pretty much everything over to that solution. Maps no longer create their own parameter palettes if all they do is add light status. And the light status parameter was removed from the parameter palettes that remained. Now all maps universally use the same parameter palette when determining their lighting status.
Additionally a few maps have been added so they can now spawn with lights on or off. The Augmentation Clinic has been left out as it's due for it's own revisions very soon. I have also excluded the Modular Habitat structures. I fear they may behave inconsistently when the palette is added simply due to how they are put together. Further investigation is required. I also left out the worm farm going to hit that at the same time as the aug clinic.
Structures I believe should always have lights on were also untouched like the Port, Landing pad, and Crashing ship of course.
Describe alternatives you've considered
I could leave things as they are. But this change enables us to far more easily control the percentage chance of a structure in Aftershock spawning with lights on. In a follow up PR I would like to extend this functionality to also make it so Vending machines are unpowered if the lights are off. But I thought I'd ask about that one first.
Testing
I started a new world and teleported around verifying my existing maps behaved as expected. And checked the maps I added coverage to to verify that they did indeed spawn with lights on or off.
Additional context