Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Audit Aftershock Mapgen for lighting consistency #79221

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

QuillInkwell
Copy link
Contributor

@QuillInkwell QuillInkwell commented Jan 17, 2025

Summary

Mods "[Aftershock] Audit nearly all Aftershock maps to consistently use the new light status parameter palette."

Purpose of change

There is a lot of inconsistency and redundancy in how Aftershock handles lighting or not lighting it's maps. (Mostly my fault)

Describe the solution

In the Gene Clinics PR I added a new standardized palette to handle lighting. This PR now aims to just move pretty much everything over to that solution. Maps no longer create their own parameter palettes if all they do is add light status. And the light status parameter was removed from the parameter palettes that remained. Now all maps universally use the same parameter palette when determining their lighting status.

Additionally a few maps have been added so they can now spawn with lights on or off. The Augmentation Clinic has been left out as it's due for it's own revisions very soon. I have also excluded the Modular Habitat structures. I fear they may behave inconsistently when the palette is added simply due to how they are put together. Further investigation is required. I also left out the worm farm going to hit that at the same time as the aug clinic.
Structures I believe should always have lights on were also untouched like the Port, Landing pad, and Crashing ship of course.

Describe alternatives you've considered

I could leave things as they are. But this change enables us to far more easily control the percentage chance of a structure in Aftershock spawning with lights on. In a follow up PR I would like to extend this functionality to also make it so Vending machines are unpowered if the lights are off. But I thought I'd ask about that one first.

Testing

I started a new world and teleported around verifying my existing maps behaved as expected. And checked the maps I added coverage to to verify that they did indeed spawn with lights on or off.

Additional context

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod labels Jan 17, 2025
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 17, 2025
@Maleclypse Maleclypse merged commit 679244f into CleverRaven:master Jan 18, 2025
28 of 32 checks passed
@QuillInkwell QuillInkwell deleted the aftershock_auddit_maps branch January 19, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants