Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various flake8 errors #79138

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix various flake8 errors #79138

merged 1 commit into from
Jan 13, 2025

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jan 13, 2025 •
edited
Loading

Summary

None

Purpose of change

Just tries to fix all the various things flake8 moans about https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/12739665158/job/35503685925

Describe the solution

Describe alternatives you've considered

Not bothering, flake8 is stupid to the point of requiring even comments are indented correctly while not exceeding the 79 characters per line limit

Testing

Additional context

Used type(x) is y rather than isinstance(x, y) bc apparently isinstance(x, y) is pretty naff for type comparison and does stuff like isinstance(True, int) resolving true

@github-actions github-actions bot added Translation I18n Code: Build Issues regarding different builds and build environments Spawn Creatures, items, vehicles, locations appearing on map [Python] Code made in Python Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Armor / Clothing Armor and clothing labels Jan 13, 2025
github-actions[bot]
github-actions bot reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @jbytheway

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 13, 2025
@Procyonae Procyonae force-pushed the DealWithFlake8 branch 2 times, most recently from 252fa0e to 07b941e Compare January 13, 2025 12:36
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 13, 2025
@GuardianDll GuardianDll merged commit fc14533 into CleverRaven:master Jan 13, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Armor / Clothing Armor and clothing json-styled JSON lint passed, label assigned by github actions [Python] Code made in Python Spawn Creatures, items, vehicles, locations appearing on map Translation I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Procyonae @GuardianDll