Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of small fixes for C++20 compliance #79115

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Jan 12, 2025

Summary

None

Purpose of change

I tried compiling our codebase with --std=c++-20 and it almost worked, modulo these few issues (and the char8_t thing which we don't talk about).
So I thought I'd upstream them, should be easy enough.

Describe the solution

Set c++ standard to c++20 in MSVS, add a /Zc:char8_t- to additional compilation options, build the thing, fix errors as you get them

Describe alternatives you've considered

N/A

Testing

Builds. Old saves load fine.

Additional context

N/A

@moxian moxian marked this pull request as ready for review January 12, 2025 18:33
@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions labels Jan 12, 2025
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Jan 12, 2025
@GuardianDll GuardianDll merged commit cc622cc into CleverRaven:master Jan 13, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants