A couple of small fixes for C++20 compliance #79115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
I tried compiling our codebase with --std=c++-20 and it almost worked, modulo these few issues (and the
char8_t
thing which we don't talk about).So I thought I'd upstream them, should be easy enough.
Describe the solution
Set c++ standard to c++20 in MSVS, add a
/Zc:char8_t-
to additional compilation options, build the thing, fix errors as you get themDescribe alternatives you've considered
N/A
Testing
Builds. Old saves load fine.
Additional context
N/A