Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete some unused CBM snippets #79099

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Uwuewsky
Copy link
Contributor

Summary

None

Purpose of change

NPCs used to ask for fuel for their bionics via these 2 snippet categories. These bionics (plutonium generator and bionic furnace) have long since been removed, but the text remains.

$ grep -r "<need_" ./src

./npc.cpp:    jsobj.read( "<need_batteries>", tem.snippets.snip_need_batteries );
./npc.cpp:    jsobj.read( "<need_booze>", tem.snippets.snip_need_booze );
./npc.cpp:    jsobj.read( "<need_fuel>", tem.snippets.snip_need_fuel );
./dialogue_chatbin.h:    translation snip_need_batteries = no_translation( "<need_batteries>" );
./dialogue_chatbin.h:    translation snip_need_booze = no_translation( "<need_booze>" );
./dialogue_chatbin.h:    translation snip_need_fuel = no_translation( "<need_fuel>" );

These snippets are also not found in mods or anywhere else.

Describe the solution

Move them to the obsoletion_and_migration_0.I

Describe alternatives you've considered

Delete them completely.

Testing

The game loads correctly.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 12, 2025
@GuardianDll
Copy link
Member

Do we need to obsolete talk tags? i thought they are used on the fly, and not stored anywhere?

@GuardianDll GuardianDll merged commit 3671224 into CleverRaven:master Jan 13, 2025
30 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants