Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Small mapgen fixes. #79060

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

QuillInkwell
Copy link
Contributor

Summary

Mods "[Aftershock] Fixes some minor bugs and consistency issues with Aftershock maps."

Purpose of change

The General store is missing a floor tile on the second floor allowing light to leak in. It also had mis-matching terrains on the roof.
Habitat Block 1 never spawned enemies.
Habitat Block 2 had two apartments there actually didn't have doors to get in.
Habitat Block 3 accidently used the forbidden roof magic in the first floor airlock.
The malamute transport should have a metal roof and not a concrete one.
The Solar Array had miss-matching roof terrains.

Describe the solution

General Store roof fixed, terrains now match and light does not leak in.
Habitat Block 1 now spawns enemies.
All apartments in Habitat Block 2 now have doors.
Habitat Block 3 now has roof over it's airlock. And also spawns slightly fewer solar panels.
Malamute transport now has a metal roof.
Solar array roof furniture's spawn with correct terrain.

Describe alternatives you've considered

Testing

Loaded world, observed no errors. Spawned each structure. Verified problem solved.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod labels Jan 10, 2025
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 10, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 11, 2025
@Maleclypse Maleclypse merged commit 14a4ece into CleverRaven:master Jan 11, 2025
27 checks passed
@QuillInkwell QuillInkwell deleted the aftershock_mapgen_fixes branch January 13, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants