Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Allow Enhance Mobility to scale with Nether Attunement and intelligence #79042

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 9, 2025

Summary

Mods "[MoM] Allow Enhance Mobility to scale with Nether Attunement and intelligence"

Purpose of change

The need to use a mutation to convey the encumbrance bonus from Enhance Mobility has previously limited its scaling potential. However, now that mutations are properly added and removed by enchantment conditions, we can add this functionality.

Describe the solution

Update the Enhance Mobility effect with a large number of conditions that check power level, intelligence, and Nether Attunement, and grant appropriate levels of the mutation at each point. Add extra mutations to cover the other levels.

Describe alternatives you've considered

Testing

Channeled Enhance Mobility, debugged power level, Nether Attunement, and Intelligence up and down and saw the level of encumbrance change.

Additional context

Have a couple other powers to do this with too, and probably some XE and Magiclysm spells.

@github-actions github-actions bot added Mods Issues related to mods or modding <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 9, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 10, 2025
@Maleclypse Maleclypse merged commit 0df6e42 into CleverRaven:master Jan 10, 2025
27 checks passed
@Standing-Storm Standing-Storm deleted the scaling-mobility branch January 10, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants