Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Price Related Bug-smashing #79036

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

QuillInkwell
Copy link
Contributor

Summary

Mods "[Aftershock] Standardize Grenade Prices in Port Augustmoon and fix IPAV Armor is free."

Purpose of change

Currently IPAV armor is categorized as a clothing and is given away for free. This is not ideal.

Grenades sold by the Gun trader in Port Augustmoon vary wildly in price due to some still being prices relative to the CDDA economy and others being priced for the Aftershock Economy.

Describe the solution

IPAV armor is moved to the armor Category and given a price of 5.5K USD. The highest price I saw for a vest sold by the outfiter was 3k. IPAV armor covers more than a vest would and is quite protective. So I hit initially hit it with 8k but I saw the UICA helmet was only 1.5k. Which made me think their gear isn't that valuable so I bumped it down to 5.5k.

Grenades were a bit more thorny:
I settled on directly updating the price on all Aftershock grenades within the mod itself. Ultimately Aftershock is trying to do it's own thing and there are already some pain points with trying to use the mod without the exo-planet.

But for the vanilla overrides, I opted to move those price overrides into the exo-planet mod itself. So your vanilla added grenades won't have their prices massively inflated in the event you do play aftershock without the exo-planet mod. But when playing on Salus the grenades will reflect the newly standardized pricings of the Aftershock economy.

Electroshock tier 1 was made 350, it seemed to be around about the area for grenades with good utility
Cyro was made 450. Matching the price of the High Explosive grenades.
Smoke bombs were made 150 matching the price of the Oxygen bomb. Useful but not nearly as useful as some other grenades.
EMP grenades I made 500. The EMP and Electroshock grenades both seem to do about the same thing but the EMP grenade can be thrown much farther. So I reflected a marginal price increase.
Standard Grenades were made 350. This was priced relative to the HE grenades, reduced slightly due to presumed lower effectiveness.
Incendiary Grenades were made 450. They were priced relative to the cryo grenade,
Scrambler Grenades were made 800. I felt a grenade that temporarily makes robots your ally is dramatically more valuable than an EMP or Electroshock grenade. Given it's potential to completely upset the power balance in a fight.

Describe alternatives you've considered

I did initially put the vanilla grenade overrides in Aftershock itself. But as I made this PR I considered the implications of further ruining the vanilla economy and thus moved the overrides.

As mentioned before I went back and forth a lot on how to price the IPAV armor considering 15k with some of the more high-tech gear. 8K for it's high protection value and relatively low encumbrance. But landed where I did to try and remain in the same neighborhood of the other combat vests and UICA gear.

Testing

Started an Exo-Planet world. Checked the prices of the items in the debug menu as well as in the shops on Port Augustmoon.

Started a world with Aftershock and no exo-planet. Verified vanilla item prices remain untouched.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 9, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 10, 2025
@GuardianDll GuardianDll merged commit 2911013 into CleverRaven:master Jan 10, 2025
27 checks passed
@QuillInkwell QuillInkwell deleted the Aftershock_Price_Fixing branch January 10, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants