Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vehicle_split_section test by only destroying the vehicle and not the terrain #78994

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Jan 6, 2025

Summary

None

Purpose of change

More stable CI.

Describe the solution

The test was producing a lot of false positives due to destroying terrain under the vehicle, which sometimes could cause collapses that apparently destroyed more vehicle parts. Destroying terrain or anything other than vehicles is irrelevant for the test, so only destroy vehicles.

Describe alternatives you've considered

Testing

Run tests with --rng-seed 1735408622 vehicle_split_section. Note that without this change there was also the curious case that it only failed every second run. Somehow there were additional rng events happening in the runs that passed which ultimately resulted in different rng rolls for the terrain destruction/collapse, but I didn't manage to get to the source of that.

Additional context

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 6, 2025
@osuphobia
Copy link
Contributor

You forgot to replace the one in Line 76 so it's still failing👀

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 7, 2025
@Maleclypse Maleclypse merged commit bf978d6 into CleverRaven:master Jan 8, 2025
25 checks passed
@mqrause mqrause deleted the split_test_fix branch January 8, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants