Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obsolete old generators #78970

Merged
merged 5 commits into from
Jan 11, 2025
Merged

obsolete old generators #78970

merged 5 commits into from
Jan 11, 2025

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

We have a new and better one, old can be removed

Describe the solution

Remove
Manually add new generators in some places where old generators were

Testing

The game loads, migration migrates, generators generate

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Vehicles Vehicles, parts, mechanics & interactions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Mods: Aftershock Anything to do with the Aftershock mod Appliance/Power Grid Anything to do with appliances and power grid Mods: No Hope Relating to the mod No Hope labels Jan 5, 2025
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 5, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 6, 2025
Karol1223
Karol1223 previously requested changes Jan 9, 2025
View reviewed changes
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 9, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 11, 2025
@Maleclypse Maleclypse merged commit 70c21d3 into CleverRaven:master Jan 11, 2025
27 checks passed
@Maleclypse Maleclypse deleted the remove_old_generators branch January 11, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karol1223 Karol1223 Karol1223 left review comments

@HadeanLake HadeanLake HadeanLake left review comments

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods: No Hope Relating to the mod No Hope Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuardianDll @Karol1223 @HadeanLake @Maleclypse