Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Add a couple more CBMs #78951

Merged
merged 4 commits into from
Jan 5, 2025

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 5, 2025

Summary

Mods "[Magiclysm] Add a couple more CBMs"

Purpose of change

Had more CBM ideas, since Magiclysm's world would have some magitech CBMs available.

Describe the solution

Add two CBMs. Have more ideas but I'm trying to pull back on "here's 30 new things, good luck with that reviewers" PRs

  1. Corporeal Ley Tap CBM--convert mana into bionic power. The conversion rate is not great--every 10 seconds, 1 mana becomes 35 J of power, so a 1500 mana bar is only 52.5 kJ--but on the other hand, mana is always available and comes back to you for free, so if you don't need it you can just turn it into CBM juice.
  2. Levinbolt Projector CBM--shoot magical bolts from your hands. This CBM is powered by actual mana, so if you're fully cybered up it's not that useful.

You can find the former in the augmentation clinic, but the latter has to be bought from the Exodii or pulled out of people (something tells me Massachusetts law would frown on fully-concealed cybernetic weapons in a world where those exist, so it'd need military CBM locations for it to be found in the world).

Describe alternatives you've considered

Testing

Both CBMs work.

Additional context

Spells cast by CBM activation are full spells with costs and everything, not fake_spells, which made this a lot easier.

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) Spawn Creatures, items, vehicles, locations appearing on map Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Jan 5, 2025
@github-actions github-actions bot requested a review from KorGgenT January 5, 2025 01:29
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Levinbolt Projector
  • Levinbolt Projector CBM
  • Levinbolt Projector CBMs
  • You unleash a levinbolt.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 5, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 5, 2025
@Maleclypse Maleclypse merged commit 500df91 into CleverRaven:master Jan 5, 2025
22 of 27 checks passed
@Standing-Storm Standing-Storm deleted the magiclysm-cbms branch January 5, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants