Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist test failing terrains #78933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

whitelist test failing terrains #78933

wants to merge 1 commit into from

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Jan 3, 2025

Summary

Bugfixes "whitelist test failing terrains"

Purpose of change

Fix build

Describe the solution

Adds the ten terrains that most reliably kill the terrain build test, grabbed from this recent unrelated PR https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/12602732715/job/35130919349?pr=78875

Describe alternatives you've considered

Just keep rerunning the test until it finally passes
Increase the spawn likelihood for all ten

Testing

N/A

Additional context

Following these instructions from the test failure output:
To resolve errors about missing terrains you can either give the terrain the
([slow] ~starting_items)=> SHOULD_NOT_SPAWN flag, intended for terrains that should never spawn, for
([slow] ~starting_items)=> example test terrains or work in progress, or tweak the constraints so that
([slow] ~starting_items)=> the terrain can spawn more reliably, or add them to the whitelist at /data/
([slow] ~starting_items)=> mods/TEST_DATA/overmap_terrain_coverage_test/
([slow] ~starting_items)=> overmap_terrain_coverage_whitelist.json intended for terrains that sometimes
([slow] ~starting_items)=> spawn, but cannot be expected to spawn reliably enough for this test.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 3, 2025
@Maleclypse
Copy link
Member

This might be the best solution possible for now but I’m waiting a few days to see if anyone comes up with anything better. The issue is that these locations are hard to place but if we whitelist them and then they become impossible to place will we ever know?

@LyleSY
Copy link
Contributor Author

LyleSY commented Jan 4, 2025

Right, to my knowledge we don't have a good way to test for never spawning, we can only test for not always spawning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants