[CR] Add audio support for curses mode

[JodiJodington]

Summary

Features "audio now works on curses mode, not just tiles mode"

Purpose of change

Closes #78841

Describe the solution

this patch initializes audio support as long as you are building with SOUND=1 without requiring TILES=1

Describe alternatives you've considered

I don't see any problems with this solution except the few copy and pasted lines but I figured it would be a lot easier to read and write this way, if that's an issue I can try to "DRY" it

Testing

I compiled with make SOUND=1 TILES=0 and sound worked, tried the base sound pack and CC-Sounds and both worked, the api hasn't changed so I assume everything else also works as intended
I also did not check if it works on windows as I do not have a windows PC, but the code changes are small and mirrored in ncurses_def.cpp and wincurses.cpp so I can't imagine there would be any windows-specific bugs

Additional context

[JodiJodington]

I'm wondering what people think about this: should the COMPILING.md file be changed in this PR to say that SOUND=1 does not rely on TILES=1 anymore?
I was thinking of keeping this PR small and only doing what was necessary to get it to compile and run, but I don't know if that's the best way to do it

[Maleclypse]

Hi Jodi,
Thank you for making this. I don't know anything about curses so can I ask you a couple questions?

My understanding of this and it's related issue is that this is just allowing curses players to bring over a soundpack and then play with sounds turned on?
Is there anything that needs to be added like a debug message as my understanding was that we don't ship sounds with the curses build because it's not enabled for it.
This PR does not cause sounds to be shipped with the curses build so if someone turned on sound in curses and there is no message telling them to go get a soundpack they may believe curses sound is broken?

[JodiJodington]

as my understanding was that we don't ship sounds with the curses build because it's not enabled for it.

Ideally the default soundpack would ship with the curses build if built with sound support, do you know what I'd need to change for that to be the case? I changed the install target to install data/sounds even if not building with tiles support (see lines 1274-1277ish in the Makefile), would I need to do anything else?
Thank you for responding!

[harakka]

should the COMPILING.md file be changed in this PR to say that SOUND=1 does not rely on TILES=1 anymore?

Yes please.

[esotericist]

to give a firmer response than harakka: yes, the documentation should be updated in the same PR to match the new behavior.

[JodiJodington]

It looks like apart from make and cmake, CDDA also supports the visual studio build system but I honestly can't figure it out and I don't have a windows PC so I don't know how to test it
to me it looks like SDL_SOUND is set unconditionally here but I don't really understand how the build system works

[JodiJodington]

also I'm fairly sure I changed the only instance where the docs mention that tiles mode is required for audio support since nothing else that seems relevant comes up from a quick grep, but I just want to make sure no one else spots anything in the docs that I'd need to correct

[JodiJodington]

the Windows CI test fail doesn’t seem to be related to my PR, what can I do about it?

[harakka]

It looks like apart from make and cmake, CDDA also supports the visual studio build system but I honestly can't figure it out and I don't have a windows PC so I don't know how to test it

We don't officially support terminal mode on Windows and make is the main build system, the rest are nice-to-haves that people who care about them maintain, so this should be fine.

the Windows CI test fail doesn’t seem to be related to my PR, what can I do about it?

I agree it doesn't seem related and the PR has BasicBuildPassed already, so it is mergeable even with that test failing.

[Maleclypse]

Thank you for doing this!