don't consider good memory and forgetful neutral

[casswedson]

Summary

None

Purpose of change

because they are listed as neutral like hair color etc. since they have an actual gameplay effect I moved them to the good and bad columns respectively

Describe the solution

Describe alternatives you've considered

Testing

look at the trait selection at character creation

Additional context

[osuphobia]

they are listed as neutral like hair color etc

Cataclysm-DDA/doc/MUTATIONS.md

Line 297 in 76c2d10

| `vanity` | false | This trait is purely cosmetic, and can be changed at any time. This is for things like skin color, eye color, hair color, etc. |

Neutral does not mean no effect, it's for vanity.
I think the real issues are

• They have "mixed_effect": true but not shown as purple at character creation.

• Some hair styles lack "vanity": true.

[harakka]

Good memory is 0 points on purpose, it has positive and negative effects.

[Fris0uman]

The cost should stay 0 but it'd be nice to separate them from the purely cosmetic traits, maybe adding an extra column for mixed trait? So it would go Positives | Negatives | Mixed | Cosmetics

[RenechCDDA]

There are other traits in that column which have non-cosmetic effects (very short and very tall).

Also per my reasoning in #76076 I consider it wrong to highlight good memory as a positive trait and bad memory as a negative one, since their gameplay effects do NOT follow that.

If anything you need to set good memory to be a negative trait, because its effects are wholly negative.

[Maleclypse]

There are other traits in that column which have non-cosmetic effects (very short and very tall).

Also per my reasoning in #76076 I consider it wrong to highlight good memory as a positive trait and bad memory as a negative one, since their gameplay effects do NOT follow that.

If anything you need to set good memory to be a negative trait, because its effects are wholly negative.

What if we made Good Memory increase skill rust? Since it specifically says "You are able to recall memories more easily." Meaning it's dropped from your attentive mind to long term storage which is where things that are rusting are.