Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pianos give piano wire on disassembly" #78799

Merged

Conversation

Daved27hundred
Copy link
Contributor

Summary

None

Purpose of change

#76204 obsoleted piano wire and replaced it with qt_wire in favor of uniformity, and I inadvertently reverted that, so I'm fixing that here.

Additional context

None

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 27, 2024
@Maleclypse
Copy link
Member

Can you remind me what qt wire is and why it’s appropriate for piano wire? Is it the same wire we use in guitars?

@Daved27hundred
Copy link
Contributor Author

Can you remind me what qt wire is and why it’s appropriate for piano wire? Is it the same wire we use in guitars?

qt_wire is tempered steel wire which is the closest match to what piano wire is usually made of. @XygenSS thought the difference was too minimal to have them seperate and I just missed the memo when I made #78672.
As for guitar strings, from what I looked up the answer is "sometimes?" There's a lot of different types made of a lot of different metals depending on what sound the guitarist wants. (from here)

I didn't touch guitars in my PR, though.

@XygenSS
Copy link
Contributor

XygenSS commented Dec 28, 2024

I have no particular opinion (or authority, tbh) on making music wire a different item or not, I'll just say that you'll have to fix the NECC guitar wire mission if you do. (it originally asked for piano wire before I changed it.)

@Maleclypse
Copy link
Member

I have no particular opinion (or authority, tbh) on making music wire a different item or not, I'll just say that you'll have to fix the NECC guitar wire mission if you do. (it originally asked for piano wire before I changed it.)

I just wanted to make sure all the music metal wires used the same generic wire. They do that I can find.

@Maleclypse Maleclypse merged commit 8328954 into CleverRaven:master Dec 28, 2024
24 of 28 checks passed
@Daved27hundred Daved27hundred deleted the revert-78672-pianowirepiano branch December 28, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants