Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Change usages of untyped coordinated into typed ones.
This time some "random" header files and dependents including:
Describe the solution
Changed usages of untyped operation to typed ones and deleting the untyped ones when no dependents remain.
Discovered a bugged usage of get_weather_temperature, with one feeding in an untyped abs coordinate and the other an untyped bubble coordinate. item.cpp operation item::process_temperature_rot was changed to get the abs coordinate for the bubble coordinate it previously used. This ought to cause the rot processing to differ in different locations, rather than always get processing for (0, 0) (there's a division by 2000 of the coordinates to create some sort of grid).
Describe alternatives you've considered
Testing
Loaded save, walked up ramp, hopped into car, drove through hay stacks, over zombie corpse with inventory, and ran over a turkey, smashed into stationary vehicle. Nothing odd seen.
The bug wasn't tested, as I don't know how to do it. The effect should be subtle, as the rot would be affected by the temperature in a different location, and the weather is, over all, similar everywhere (we don't have a "world" spanning from the poles to the tropics) at any given time of the year.
Additional context
cata_tiles is going to require a bit of work to entangle, but may be the focus for the next PR. The current code happily is used both by bubble coordinates and by omt coordinates. I'm considering hiding the current operations as private and use typed "skins" to separate the two use cases, but would be grateful for advice.