Items in transparent pockets on the map illuminate surroundings #78789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Items in transparent pockets on the map illuminate surroundings"
Purpose of change
Currently only top level items on the map are considered as light sources. This excludes for example candles in candle sticks.
Describe the solution
Map items also check contents of transparent pockets for light sources.
Straight up cherry-picked from #67595, only fixed conflicts from typed tripoints.
Describe alternatives you've considered
Do the work again and still end up with the same solution?
Testing
Put candle in candlestick and place on floor.
Additional context