Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eoc: clear deferred math on type errors too #78775

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

andrei8l
Copy link
Contributor

Summary

None

Purpose of change

Deferred math still sticks in memory for a certain error so people can't fix their JSON without restarting the game

Describe the solution

Clear deferred math on type errors too

Describe alternatives you've considered

N/A

Testing

Add a return/comparison math statement as an EOC effect, or an assignment statement as a condition
Try to start a game and get an error
Without closing the game, fix the EOC and try again.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition new contributor <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 26, 2024
@Maleclypse Maleclypse merged commit 163ee18 into CleverRaven:master Dec 27, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants