Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eggplants can be smoked in the rack #78751

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Dec 24, 2024

Summary

Bugfixes "Eggplants can now be smoked via the smoking rack"
Bugfixes "Birdfood can be made out of eggplant seeds"

Purpose of change

Eggplants presently can be smoked via the crafting menu, but cannot be put into the smoking rack. This is an oversight.
Birdfood can be crafted out of all kinds of seeds, but not eggplant ones. This is an oversight as well.

Describe the solution

Json change.

Describe alternatives you've considered

Drive-by prettify eggplant_cut somewhat by making it copy-from, instead of copy-pasted from base eggplant. I can try and do that if requested, but I decided to take the lazy route for now.

Testing

Inserted whole eggplant, and cut eggplant into the smoking rack, lit it, waited 6 hours, collected "dehydrated vegetable (fresh)".
Made birdfood out of eggplant seeds.

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Dec 24, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 24, 2024
Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one will surely, hopefully, have 100% approval rate! Including from me!

@moxian
Copy link
Contributor Author

moxian commented Dec 24, 2024

Oh, I can give the results nice names too, huh!
20241223-232904-cataclysm-tiles

@moxian moxian marked this pull request as draft December 24, 2024 09:17
@moxian moxian marked this pull request as ready for review December 24, 2024 09:17
@moxian moxian marked this pull request as draft December 24, 2024 11:28
@moxian moxian marked this pull request as ready for review December 24, 2024 11:29
@moxian moxian marked this pull request as draft December 24, 2024 13:19
@moxian moxian marked this pull request as ready for review December 24, 2024 13:19
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 24, 2024
@Maleclypse Maleclypse merged commit 3f09bef into CleverRaven:master Dec 25, 2024
58 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants