Allow proper overlaying of weather_generator #78726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Procyonae
force-pushed
the
WeatherGeneratorSupportsPartialOverlay
branch
from
4e60e1d to
b4c0844
Compare
github-actions
bot
added
[JSON]
…where and shouldn't be valid
Procyonae
force-pushed
the
WeatherGeneratorSupportsPartialOverlay
branch
from
042ab30 to
7a520fa
Compare
|
Is there any fix jet? And if yes, how do i implement It? |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[No Hope] Fixes worse than intended weather"
Purpose of change
Fixes #78678
Fixes #78719
I derped in #78375 and removed needed dupe weather fields bc weather_generator has old school loading
Describe the solution
Rather than just reverting 199750b adds proper generic factory style loading to weather_generator
Describe alternatives you've considered
I still want to scrutinise weather code in general but don't want to get started on that rn
Testing
There's conveniently a debug function to dump a year's worth of weather, tested before and after with No Hope (here's the after)
weather.xlsx
Additional context