Fix "remove_vehicles" when used without or with empty "vehicles" #78724
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map / Mapgen
Procyonae
force-pushed
the
RemoveVehiclesFix
branch
from
3b6c518 to
d40dd53
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
This is the most obvious use of the function and it doesn't work
Describe the solution
Is mergeable as it's an improvement but remove_vehicles barely works period due to #72947
Describe alternatives you've considered
Testing
Tested without the check discussed in #72947 with expected results
Additional context
Yes we were reading the vehicles as items for some reason, I don't know either