typified character, npc and explosion stuff #78655
Merged
+142
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Get rid of usage of untyped coordinates, replacing it with typed ones instead. This time the remainder of character and npc, plus explosion.
Describe the solution
Replace untyped operation with typed ones, adjusting usages, and deleting orphaned untyped operation overloads.
Describe alternatives you've considered
Testing
There should be no functional changes, so there's nothing particular to test.
Loaded save, walked up ramp, jumped into car, drove through hay bales, apparently reinforces, as vehicle parts were destroyed, ran over zombie corpse with inventory, ran over turkey, smashed into stationary vehicle.
Nothing unexpected seen, apart from the reinforced hay bales, which happens occasionally.
Additional context
Started to try to deal with zones as well, but that's too big a mess to include here (not the least because relative and absolute coordinates are stored in the same untyped variables), and so backed out of it.