Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typified character.h + npc.h #78623

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Change usage of untyped coordinates into typed ones. This time character.h and npc.h, plus dependents.

Describe the solution

Replace the untyped coordinated with the appropriate typed ones, as well as the usages. This time there wasn't any need to retain any old operation and create any overload. Removed a few orphaned untyped overloads.

Describe alternatives you've considered

Testing

There's no functional change, so no particular thing to test.
Loaded save, walked up ramp, jumped into car, drove through hay stacks, ran over zombie corpse with inventory, ran into, but failed to run over, some turkeys, smashed into stationary vehicle. Nothing odd noticed.

Additional context

The next pass will include character.cpp and npc.cpp. We'll see if there's room for something else after that.

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Bionics CBM (Compact Bionic Modules) Vehicles Vehicles, parts, mechanics & interactions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Melee Melee weapons, tactics, techniques, reach attack Player Faction Base / Camp All about the player faction base/camp/site EOC: Effects On Condition Anything concerning Effects On Condition labels Dec 17, 2024
@github-actions github-actions bot requested a review from KorGgenT December 17, 2024 13:10
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 17, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 17, 2024
@Maleclypse Maleclypse merged commit 26eb173 into CleverRaven:master Dec 19, 2024
23 of 25 checks passed
@PatrikLundell PatrikLundell deleted the typify branch December 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack NPC / Factions NPCs, AI, Speech, Factions, Ownership Player Faction Base / Camp All about the player faction base/camp/site Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants