Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying of stats for ablative armor #78590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix displaying of stats for ablative armor #78590

wants to merge 1 commit into from
+289 −39

Conversation

boyboytemp
Copy link

@boyboytemp boyboytemp commented Dec 15, 2024 •
edited
Loading

Currently protection/coverage stats are not displayed in 'sort armor screen' and 'body status screen'.

Summary

Bugfixes "Fixes displaying of stats for ablative armor"

Purpose of change

Reproduction steps:

  1. spawn 'hard hat'
  2. spawn 'face shield'
  3. insert face_shield into hard_hat
  4. put on the hard hat
  5. open 'Sort armor' ('+')
  6. select eyes - "3l"
  7. note that coverage is 0% and no protection is listed
  8. also note that warmth is 5, although face_shield does not give any warmth

Describe the solution

I noticed that encumbrance was displayed correctly, so I made changes to resist/warmth/coverage/breathability by analogy with encumbrance code.

Describe alternatives you've considered

Testing

See reproduction steps. Also I added some unit tests.

Additional context

The issue was originally reported in #62126
Before
before_fix_abbl_armor_stats
After
after_fix_abbl_armor_stats

@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Items: Armor / Clothing Armor and clothing new contributor <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 15, 2024
@boyboytemp boyboytemp force-pushed the fix_ablative_armor_stats branch from 9a81fa0 to f23654e Compare December 15, 2024 20:05
fix displaying of stats for ablative armor
f23654e 
Currently protection/coverage stats are not displayed in 'sort armor
screen' and 'body status screen'.

The issue was reported originally in CleverRaven#62126
@Maleclypse
Copy link
Member

Can you share a before and after screenshot if that would be helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Items: Armor / Clothing Armor and clothing json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boyboytemp @Maleclypse