android pos -> pos_bub #78587
Merged
android pos -> pos_bub #78587
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
push and pray |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Correct breaking android "text" in #78405.
Describe the solution
Change .pos() to .pos_bub() as identified by @Procyonae.
Describe alternatives you've considered
Testing
None, as I can't test "text" change. It can only be tested by compiling in an android environment.
Additional context
I did search for .pos() in the affected file, but found no other cases (and went through the few ".pos" instances as well).
I don't know any way to device a search over other files that would restrict the search to "text" sections, which would have been useful (Going trough all .pos() cases is all files is a mammoth task, as the last time I tried something similar I got 19000 or so matches, although it's probably a thousand or two less now).