Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate compare item menu to imgui #78557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Dec 14, 2024

Summary

Interface "Migrate compare item menu to imgui"

Purpose of change

Just another menu I need for #55503.

Describe the solution

The iteminfo work was already done, so this was mostly getting the layout right.
Attach/detach gunmods has buttons now.

Describe alternatives you've considered

Testing

Compared some items through V menu and attached/detached some mods.

Additional context

grafik

Copy link
Contributor

@moxian moxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some irrelevant nitpicks, feel free to ignore (I'm helping!)

Thanks!

src/game_inventory.cpp Outdated Show resolved Hide resolved
src/game_inventory.cpp Outdated Show resolved Hide resolved
src/game_inventory.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 14, 2024
@mqrause mqrause force-pushed the imgui_compare_items branch from 7d028fe to 2272d2a Compare December 14, 2024 12:54
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants